Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsoPhotonEB skim (13_1_X) #42182

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Conversation

lathomas
Copy link
Contributor

@lathomas lathomas commented Jul 4, 2023

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #42150

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2023

A new Pull Request was created by @lathomas for CMSSW_13_1_X.

It involves the following packages:

  • DPGAnalysis/Skims (pdmv)

@cmsbuild, @bbilin, @sunilUIET can you please review it and eventually sign? Thanks.
@youyingli, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor

@cms-sw/pdmv-l2 please test

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2023

backport of #42150

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5d067/33540/summary.html
COMMIT: 5cbed8d
CMSSW: CMSSW_13_1_X_2023-07-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42182/33540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222811
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222785
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2023

Pull request #42182 was updated. @cmsbuild, @bbilin, @sunilUIET can you please check and sign again.

@youyingli
Copy link
Contributor

@cms-sw/pdmv-l2 , please test again

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5d067/33616/summary.html
COMMIT: cf85b32
CMSSW: CMSSW_13_1_X_2023-07-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42182/33616/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 201 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222791
  • DQMHistoTests: Total failures: 5099
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3217670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor

@sunilUIET please sign

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a49ef6b into cms-sw:CMSSW_13_1_X Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants